Refactor release workflow to be reusable #232
Merged
+259
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
salasberryfin
previously approved these changes
Oct 26, 2023
There was a problem hiding this comment.
LGTM. Based on these changes, I have published a PR to address the release testing which depends on this one #235
richardcase
added
the
kind/refactor
richardcase
reviewed
Oct 26, 2023
There was a problem hiding this comment.
This looks good. What does this mean in relation to PR #223?
Danil-Grigorev
force-pushed
the
refactor-release
branch
from
a7518f5
to
707535c
Compare
Danil-Grigorev
changed the title
Danil-Grigorev
force-pushed
the
refactor-release
branch
from
707535c
to
6e2deaa
Compare
|
This refactor includes signing images using digest instead of a tag @richardcase |
Danil-Grigorev
force-pushed
the
refactor-release
branch
4 times, most recently
from
9f6059a
to
31221ac
Compare
richardcase
reviewed
Nov 2, 2023
furkatgofurov7
previously approved these changes
Nov 2, 2023
Danil-Grigorev
force-pushed
the
refactor-release
branch
from
31221ac
to
3608197
Compare
richardcase
previously approved these changes
Nov 2, 2023
richardcase
reviewed
Nov 2, 2023
richardcase
dismissed
their stale review
Didn't see the error with the action
|
#247 has merged so we should be able to make the checks go green :) |
Danil-Grigorev
force-pushed
the
refactor-release
branch
from
3608197
to
76ff893
Compare
richardcase
previously approved these changes
Nov 2, 2023
furkatgofurov7
previously approved these changes
Nov 3, 2023
salasberryfin
requested changes
Nov 3, 2023
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
refactor-release
branch
from
76ff893
to
5befc59
Compare
salasberryfin
approved these changes
Nov 3, 2023
richardcase
approved these changes
Nov 3, 2023
furkatgofurov7
approved these changes
Nov 3, 2023
This was referenced Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #212
Special notes for your reviewer:
Checklist: